Fix auth token revocation (#157)
This commit is contained in:
1 parent
9b49da35b6
commit
e521abd799
3 files changed
+14
-14
No files matched your search
@@ -299,17 +299,17 @@ describe Google::Auth::UserAuthorizer do
|
||||
|
||||
before(:example) do
|
||||
token_store.store('user1', token_json)
|
||||
stub_request(
|
||||
:get, 'https://oauth2.googleapis.com/revoke?token=refreshtoken'
|
||||
)
|
||||
stub_request(:post, 'https://oauth2.googleapis.com/revoke')
|
||||
.with(body: hash_including('token' => 'refreshtoken'))
|
||||
.to_return(status: 200)
|
||||
end
|
||||
|
||||
it 'should revoke the grant' do
|
||||
authorizer.revoke_authorization('user1')
|
||||
expect(a_request(
|
||||
:get, 'https://oauth2.googleapis.com/revoke?token=refreshtoken'
|
||||
))
|
||||
:post, 'https://oauth2.googleapis.com/revoke'
|
||||
).with(body: hash_including('token' => 'refreshtoken'))
|
||||
)
|
||||
.to have_been_made
|
||||
end
|
||||
|
||||
|
||||
@@ -246,8 +246,8 @@ describe Google::Auth::UserRefreshCredentials do
|
||||
|
||||
describe 'when revoking a refresh token' do
|
||||
let(:stub) do
|
||||
stub_request(:get, 'https://oauth2.googleapis.com/revoke' \
|
||||
'?token=refreshtoken')
|
||||
stub_request(:post, 'https://oauth2.googleapis.com/revoke')
|
||||
.with(body: hash_including('token' => 'refreshtoken'))
|
||||
.to_return(status: 200,
|
||||
headers: { 'Content-Type' => 'application/json' })
|
||||
end
|
||||
@@ -262,8 +262,8 @@ describe Google::Auth::UserRefreshCredentials do
|
||||
|
||||
describe 'when revoking an access token' do
|
||||
let(:stub) do
|
||||
stub_request(:get, 'https://oauth2.googleapis.com/revoke' \
|
||||
'?token=accesstoken')
|
||||
stub_request(:post, 'https://oauth2.googleapis.com/revoke')
|
||||
.with(body: hash_including('token' => 'accesstoken'))
|
||||
.to_return(status: 200,
|
||||
headers: { 'Content-Type' => 'application/json' })
|
||||
end
|
||||
@@ -280,8 +280,8 @@ describe Google::Auth::UserRefreshCredentials do
|
||||
|
||||
describe 'when revoking an invalid token' do
|
||||
let(:stub) do
|
||||
stub_request(:get, 'https://oauth2.googleapis.com/revoke' \
|
||||
'?token=refreshtoken')
|
||||
stub_request(:post, 'https://oauth2.googleapis.com/revoke')
|
||||
.with(body: hash_including('token' => 'refreshtoken'))
|
||||
.to_return(status: 400,
|
||||
headers: { 'Content-Type' => 'application/json' })
|
||||
end
|
||||
@@ -296,14 +296,14 @@ describe Google::Auth::UserRefreshCredentials do
|
||||
|
||||
describe 'when errors occurred with request' do
|
||||
it 'should fail with Signet::AuthorizationError if request times out' do
|
||||
allow_any_instance_of(Faraday::Connection).to receive(:get)
|
||||
allow_any_instance_of(Faraday::Connection).to receive(:post)
|
||||
.and_raise(Faraday::TimeoutError)
|
||||
expect { @client.revoke! }
|
||||
.to raise_error Signet::AuthorizationError
|
||||
end
|
||||
|
||||
it 'should fail with Signet::AuthorizationError if request fails' do
|
||||
allow_any_instance_of(Faraday::Connection).to receive(:get)
|
||||
allow_any_instance_of(Faraday::Connection).to receive(:post)
|
||||
.and_raise(Faraday::ConnectionFailed, nil)
|
||||
expect { @client.revoke! }
|
||||
.to raise_error Signet::AuthorizationError
|
||||
|
||||
Reference in new issue
Block a user