From 35c2728bfe9357e1092700d9b31907a25a46ed43 Mon Sep 17 00:00:00 2001 From: Antonio C Nalesso Moreira Date: Fri, 10 May 2013 21:31:38 +0100 Subject: [PATCH 1/8] Rspec added to impressionist dir, so we can test in isolation --- spec/spec_helper.rb | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 spec/spec_helper.rb diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb new file mode 100644 index 0000000..e69de29 From 3ea45b1f512515c10ec3d72ea7c95f46825b04e0 Mon Sep 17 00:00:00 2001 From: Antonio C Nalesso Moreira Date: Fri, 10 May 2013 21:34:04 +0100 Subject: [PATCH 2/8] Rspec added to impressionist dir, so we can test in isolation --- spec/spec_helper.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index e69de29..bb7aaae 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -0,0 +1 @@ +require 'lib/impressionist' From c7df6c50a6b893a7fe101f5b70480a9f2a05c6fd Mon Sep 17 00:00:00 2001 From: Antonio C Nalesso Moreira Date: Fri, 10 May 2013 21:35:10 +0100 Subject: [PATCH 3/8] Rspec added to impressionist dir, so we can test in isolation --- spec/spec_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index bb7aaae..8b13789 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1 +1 @@ -require 'lib/impressionist' + From 20e5753925b66c3357792b107b0faf142508c85a Mon Sep 17 00:00:00 2001 From: Antonio C Nalesso Moreira Date: Fri, 10 May 2013 22:33:37 +0100 Subject: [PATCH 4/8] Impressionist has been tested --- impressionist.gemspec | 27 --------------------------- lib/impressionist.rb | 4 ++-- spec/spec_helper.rb | 6 +++++- 3 files changed, 7 insertions(+), 30 deletions(-) delete mode 100644 impressionist.gemspec diff --git a/impressionist.gemspec b/impressionist.gemspec deleted file mode 100644 index e462fe7..0000000 --- a/impressionist.gemspec +++ /dev/null @@ -1,27 +0,0 @@ -# encoding: utf-8 -require File.expand_path('../lib/impressionist/version', __FILE__) - -Gem::Specification.new do |s| - s.add_dependency 'httpclient', '~> 2.2' - s.add_dependency 'nokogiri', '~> 1.5' - s.add_development_dependency 'capybara' - s.add_development_dependency 'rake', '>= 0.9' - s.add_development_dependency 'rails', '~>3.1' - s.add_development_dependency 'rdoc', '>= 2.4.2' - s.add_development_dependency 'rspec-rails' - s.add_development_dependency 'simplecov' - s.add_development_dependency 'sqlite3' - s.add_development_dependency 'systemu' - s.authors = ["johnmcaliley"] - s.description = "Log impressions from controller actions or from a model" - s.email = "john.mcaliley@gmail.com" - s.files = `git ls-files`.split("\n") - s.homepage = "https://github.com/charlotte-ruby/impressionist" - s.licenses = ["MIT"] - s.name = "impressionist" - s.require_paths = ["lib"] - s.required_rubygems_version = Gem::Requirement.new('>= 1.3.6') if s.respond_to? :required_rubygems_version= - s.summary = "Easy way to log impressions" - s.test_files = `git ls-files -- test_app/*`.split("\n") - s.version = Impressionist::VERSION -end diff --git a/lib/impressionist.rb b/lib/impressionist.rb index 7ead8fe..8e4c7a5 100644 --- a/lib/impressionist.rb +++ b/lib/impressionist.rb @@ -1,7 +1,7 @@ -require "impressionist/engine.rb" +require 'impressionist/engine' module Impressionist - # Define ORM + # Define default ORM mattr_accessor :orm @@orm = :active_record diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 8b13789..92787cc 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1 +1,5 @@ - +module Impressionist + def self.mattr_accessor(accessor) + class_variable_set("@@#{accessor}", accessor) + end +end From b8fcdb7c94aafa82f7b92031021b08263b3de11e Mon Sep 17 00:00:00 2001 From: Antonio C Nalesso Moreira Date: Fri, 10 May 2013 22:57:49 +0100 Subject: [PATCH 5/8] new gem specification, cleaned up and added some more specs --- impressionist.gemspec | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 impressionist.gemspec diff --git a/impressionist.gemspec b/impressionist.gemspec new file mode 100644 index 0000000..e2ae75b --- /dev/null +++ b/impressionist.gemspec @@ -0,0 +1,32 @@ +# -*- encoding: utf-8 -*- +$:.push File.expand_path('../lib', __FILE__) +require 'impressionist/version' + +Gem::Specification.new do |s| + s.name = 'impressionist' + s.version = Impressionist::VERSION.dup + s.platform = Gem::Platform::RUBY + s.licenses = ['MIT'] + s.summary = 'Easy way to log impressions' + s.email = 'john.mcaliley@gmail.com' + s.homepage = 'http://github.com/charlotte-ruby/impressionist' + s.description = 'Log impressions from controller actions or from a model' + s.authors = ['johnmcaliley'] + + s.files = `git ls-files`.split('\n') + s.test_files = `git ls-files -- spec/* -- test_app/*`.split('\n') + s.require_paths = ['lib'] + s.required_rubygems_version = Gem::Requirement.new('>= 1.3.6') if s.respond_to? :required_rubygems_version= + + s.add_dependency 'httpclient', '~> 2.2' + s.add_dependency 'nokogiri', '~> 1.5' + s.add_development_dependency 'capybara' + s.add_development_dependency 'rake', '>= 0.9' + s.add_development_dependency 'rails', '~>3.1' + s.add_development_dependency 'rdoc', '>= 2.4.2' + s.add_development_dependency 'rspec-rails' + s.add_development_dependency 'simplecov' + s.add_development_dependency 'sqlite3' + s.add_development_dependency 'systemu' + +end From 5c96e4a9b4aefa8d0124944b044dc45ec803b18b Mon Sep 17 00:00:00 2001 From: Nalesso Moreira Date: Sat, 11 May 2013 00:54:06 +0200 Subject: [PATCH 6/8] Update impressionist.gemspec --- impressionist.gemspec | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/impressionist.gemspec b/impressionist.gemspec index e2ae75b..a1d02ec 100644 --- a/impressionist.gemspec +++ b/impressionist.gemspec @@ -3,26 +3,26 @@ $:.push File.expand_path('../lib', __FILE__) require 'impressionist/version' Gem::Specification.new do |s| - s.name = 'impressionist' - s.version = Impressionist::VERSION.dup - s.platform = Gem::Platform::RUBY - s.licenses = ['MIT'] - s.summary = 'Easy way to log impressions' - s.email = 'john.mcaliley@gmail.com' - s.homepage = 'http://github.com/charlotte-ruby/impressionist' - s.description = 'Log impressions from controller actions or from a model' - s.authors = ['johnmcaliley'] + s.name = 'impressionist' + s.version = Impressionist::VERSION.dup + s.platform = Gem::Platform::RUBY + s.licenses = ['MIT'] + s.summary = 'Easy way to log impressions' + s.email = 'john.mcaliley@gmail.com' + s.homepage = 'http://github.com/charlotte-ruby/impressionist' + s.description = 'Log impressions from controller actions or from a model' + s.authors = ['johnmcaliley'] s.files = `git ls-files`.split('\n') - s.test_files = `git ls-files -- spec/* -- test_app/*`.split('\n') - s.require_paths = ['lib'] + s.test_files = `git ls-files -- {spec,test_app/spec}/*`.split('\n') + s.require_paths = 'lib' s.required_rubygems_version = Gem::Requirement.new('>= 1.3.6') if s.respond_to? :required_rubygems_version= s.add_dependency 'httpclient', '~> 2.2' s.add_dependency 'nokogiri', '~> 1.5' s.add_development_dependency 'capybara' s.add_development_dependency 'rake', '>= 0.9' - s.add_development_dependency 'rails', '~>3.1' + s.add_development_dependency 'railties', '~> 3.1' s.add_development_dependency 'rdoc', '>= 2.4.2' s.add_development_dependency 'rspec-rails' s.add_development_dependency 'simplecov' From 949f79e68b341fea8e8b5bc929bd62a8cb342c96 Mon Sep 17 00:00:00 2001 From: Nalesso Moreira Date: Sat, 11 May 2013 01:12:05 +0200 Subject: [PATCH 7/8] Update impressionist.gemspec fix travis erros. --- impressionist.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/impressionist.gemspec b/impressionist.gemspec index a1d02ec..fa5017e 100644 --- a/impressionist.gemspec +++ b/impressionist.gemspec @@ -15,7 +15,7 @@ Gem::Specification.new do |s| s.files = `git ls-files`.split('\n') s.test_files = `git ls-files -- {spec,test_app/spec}/*`.split('\n') - s.require_paths = 'lib' + s.require_path = 'lib' s.required_rubygems_version = Gem::Requirement.new('>= 1.3.6') if s.respond_to? :required_rubygems_version= s.add_dependency 'httpclient', '~> 2.2' From ec5c7c4590b0732099e5cf2e35a1787e923bb3e0 Mon Sep 17 00:00:00 2001 From: Nalesso Moreira Date: Sat, 11 May 2013 01:31:51 +0200 Subject: [PATCH 8/8] Update impressionist.gemspec --- impressionist.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/impressionist.gemspec b/impressionist.gemspec index fa5017e..5cc1480 100644 --- a/impressionist.gemspec +++ b/impressionist.gemspec @@ -22,7 +22,7 @@ Gem::Specification.new do |s| s.add_dependency 'nokogiri', '~> 1.5' s.add_development_dependency 'capybara' s.add_development_dependency 'rake', '>= 0.9' - s.add_development_dependency 'railties', '~> 3.1' + s.add_development_dependency 'rails', '~> 3.1' s.add_development_dependency 'rdoc', '>= 2.4.2' s.add_development_dependency 'rspec-rails' s.add_development_dependency 'simplecov'