From b75b2e9af24272042bc318c312f84e7d4bd6abc2 Mon Sep 17 00:00:00 2001
From: Bohung <bohung@rulingcom.com>
Date: Tue, 27 Apr 2021 16:23:15 +0800
Subject: [PATCH] Fix bug.

---
 lib/tasks/sync_ntnu_personal_data_tasks.rake | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/lib/tasks/sync_ntnu_personal_data_tasks.rake b/lib/tasks/sync_ntnu_personal_data_tasks.rake
index 7e392f0..3bf86d8 100644
--- a/lib/tasks/sync_ntnu_personal_data_tasks.rake
+++ b/lib/tasks/sync_ntnu_personal_data_tasks.rake
@@ -34,14 +34,11 @@ module NtnuSyncPlugin
 
       if invalid_apa_title.include? apa_title
         jp.delete
-        jp = JournalPaper.new
-        jp.paper_title_translations = { 'zh_tw' => nil, 'en' => nil }
-        jp.year = publication_year
+      else
+        jp.publication_date = "#{publication_year}/#{publication_month}/01"
+        jp.member_profile_id = user.member_profile_id
+        puts "journal paper #{jp.id} saved" if jp.save
       end
-
-      jp.publication_date = "#{publication_year}/#{publication_month}/01"
-      jp.member_profile_id = user.member_profile_id
-      puts "journal paper #{jp.id} saved" if jp.save
     end
   end
 
@@ -97,12 +94,10 @@ module NtnuSyncPlugin
 
       if invalid_apa_title.include? apa_title
         wc.delete
-        wc = WritingConference.new
-        wc.paper_title_translations = { 'zh_tw' => nil, 'en' => nil }
+      else
+        wc.member_profile_id = user.member_profile_id
+        puts "conference paper #{wc.id} saved" if wc.save
       end
-
-      wc.member_profile_id = user.member_profile_id
-      puts "conference paper #{wc.id} saved" if wc.save
     end
   end